Config options added to make EULA process more thorough #550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… show up on allocation detail page
jrlagrone
reviewed
Feb 19, 2024
| if EULA_AGREEMENT: | ||
| allocation_user_pending_status_choice = AllocationUserStatusChoice.objects.get(name='Pending') | ||
|
|
||
| allocation_user_status = get_object_or_404(AllocationUser, allocation=allocation_obj, user=self.request.user).status |
There was a problem hiding this comment.
This should check all users on an allocation and only show the ability to accept/deny EULA to the relevant user. As is, this breaks views where the user is not a member of the allocation (e.g. an admin/staff view looking to approve/deny the allocation)
|
We're looking at making similar changes. I'll try to add fixes / updates as we get to them (no eta at this point.) Right now, this PR is not completely functional (at least for us):
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves issue #542 — Now, centers who want to have a more thorough process for users on allocations whose resources have a 'eula' attribute can set the config variable
EULA_AGREEMENTto True. With this, when a user is added to an allocation with a EULA resource, any user that is added (who is not an admin or a PI) has a status ofPendinginstead ofActive. When this user goes to access the resource, they must either accept or decline the EULA. If they accept, they become anActiveuser on the allocation. However, if they decline, their status is set toDeclined.In addition, when a user is added to an allocation with a EULA resource, they receive an email asking them to complete the EULA. When a user agrees to the EULA, an email is sent to the user and their manager to confirm this process. If the config variable
EMAIL_EULA_REMINDERSis set to True, users are emailed weekly to remind them to complete their EULA process.