Removed all overrides to trend line display in plots; SUPREMM module #2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trend line display default is now 'off' for all GroupBy classes, thus for all Usage plots, for supremm module. See also pull requests ubccr/xdmod-xsede#1 and ubccr/xdmod#2 which address this change for xdmod xsede and supremm modules.
Description
Overrides to getDefaultShowTrendLine() removed in all GroupBy classes; retained in parent GroupBy class.
Motivation and Context
Assigned as follows:
https://app.asana.com/0/14787510600562/217118195806574
Tests performed
Changes affect only Usage plots. Verified that Usage line plot types that previously overrode trend line behavior now display no trend lines by default, namely:
Jobs GroupByNSFStatus, and
GroupByNone for:
(note that the latter three plot types do not exist, in fact)
Verified that function definition for getDefaultShowTrendLine() is found only in parent GroupBy class, Query/GroupBy.php
Tests were done against clean merged code with xdmod6.5.
Types of changes
Checklist:
…shown by default.