Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed all overrides to trend line display in plots; SUPREMM module #2

Merged
merged 1 commit into from
Dec 21, 2016
Merged

Removed all overrides to trend line display in plots; SUPREMM module #2

merged 1 commit into from
Dec 21, 2016

Conversation

jsperhac
Copy link
Contributor

@jsperhac jsperhac commented Dec 15, 2016

Trend line display default is now 'off' for all GroupBy classes, thus for all Usage plots, for supremm module. See also pull requests ubccr/xdmod-xsede#1 and ubccr/xdmod#2 which address this change for xdmod xsede and supremm modules.

Description

Overrides to getDefaultShowTrendLine() removed in all GroupBy classes; retained in parent GroupBy class.

Motivation and Context

Assigned as follows:
https://app.asana.com/0/14787510600562/217118195806574

Tests performed

Changes affect only Usage plots. Verified that Usage line plot types that previously overrode trend line behavior now display no trend lines by default, namely:
Jobs GroupByNSFStatus, and
GroupByNone for:

  • Jobs
  • Supremm
  • Accounts
  • Allocations
  • Requests
  • ResourceAllocations
  • Grants
  • Performance
  • Proposal
    (note that the latter three plot types do not exist, in fact)

Verified that function definition for getDefaultShowTrendLine() is found only in parent GroupBy class, Query/GroupBy.php

Tests were done against clean merged code with xdmod6.5.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project as found in the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

…shown by default.

@tyearke tyearke added this to the Open XDMoD 6.5.0 milestone Dec 16, 2016
@tyearke tyearke merged commit b962bb9 into ubccr:xdmod6.5 Dec 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants