Skip to content

Commit

Permalink
Code reviews catch missing changes always code review
Browse files Browse the repository at this point in the history
  • Loading branch information
plessbd committed Aug 20, 2019
1 parent 3bf9d08 commit 0fd0e77
Showing 1 changed file with 1 addition and 2 deletions.
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
{
"#": "Raw event information from the Open Stack log files.",

"#": "Note that almost any field in the raw event logs can be NULL so most fields are nullable.",
"#": "These will be stored here and filtered out later. For example, several events with type",
"table_definition": {
Expand Down Expand Up @@ -52,7 +51,7 @@
},
{
"name": "user_name",
"type": "varchar(64)",
"type": "varchar(255)",
"nullable": true,
"default": null
},
Expand Down

1 comment on commit 0fd0e77

@smgallo
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While we're at it, can you ask @eiffel777 what the different between user name and user id is (I suspect one is a uuid) and add a comment to the table definition?

Please sign in to comment.