Improve debugging messages (#783)

ubccr · Jan 25, 2019 · 3f4a028 · 3f4a028
1 parent c2b5194
commit 3f4a028
Showing 1 changed file with 4 additions and 7 deletions.
diff --git a/classes/ETL/Maintenance/ExecuteSql.php b/classes/ETL/Maintenance/ExecuteSql.php
@@ -205,18 +205,15 @@ public function execute(EtlOverseerOptions $etlOverseerOptions)
             // does not support multiple SQL statements in a single query.
 
             $sqlStatementList = explode($delimiter, $sqlFileContents);
+
+            // Trim each SQL statement and filter empty items (such as newlines)
+
+            $sqlStatementList = array_filter(array_map('trim', $sqlStatementList));
             $numSqlStatements = count($sqlStatementList);
             $numStatementsProcessed = 0;
 
             foreach ($sqlStatementList as $sql) {
 
-                // Skip empty queries
-
-                $sql = trim($sql);
-                if ( "" == $sql ) {
-                    continue;
-                }
-
                 // Remove comments from the SQL before executing for clarity.
 
                 $commentPatterns = array(