Skip to content

Commit

Permalink
Code review updates
Browse files Browse the repository at this point in the history
  • Loading branch information
plessbd committed Jan 17, 2019
1 parent 34a731f commit ca5b740
Showing 1 changed file with 1 addition and 11 deletions.
12 changes: 1 addition & 11 deletions classes/Authentication/SAML/XDSamlAuthentication.php
Original file line number Diff line number Diff line change
Expand Up @@ -31,13 +31,6 @@ class XDSamlAuthentication
*/
protected $_sources = null;

/**
* Whether or not SAML is configured. Defaults to false.
*
* @var boolean
*/
protected $_isConfigured = null;

const BASE_ADMIN_EMAIL = <<<EML
Person Details -----------------------------------
Expand Down Expand Up @@ -93,10 +86,7 @@ public function __construct()
*/
public function isSamlConfigured()
{
if($this->_isConfigured === null){
$this->_isConfigured = (count($this->_sources));
}
return $this->_isConfigured;
return !empty($this->_sources);
}

/**
Expand Down

0 comments on commit ca5b740

Please sign in to comment.