-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multi realm installs - Allow for modification of enabled realms… #1004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanrath
reviewed
Aug 14, 2019
ryanrath
reviewed
Aug 14, 2019
ryanrath
reviewed
Aug 14, 2019
ryanrath
reviewed
Aug 14, 2019
ryanrath
reviewed
Aug 14, 2019
ryanrath
reviewed
Aug 14, 2019
ryanrath
reviewed
Aug 14, 2019
ryanrath
reviewed
Aug 14, 2019
ryanrath
reviewed
Aug 14, 2019
ryanrath
reviewed
Aug 14, 2019
ryanrath
reviewed
Aug 14, 2019
ryanrath
reviewed
Aug 14, 2019
ryanrath
reviewed
Aug 14, 2019
ryanrath
reviewed
Aug 14, 2019
ryanrath
reviewed
Aug 14, 2019
ryanrath
reviewed
Aug 14, 2019
ryanrath
reviewed
Aug 14, 2019
ryanrath
reviewed
Aug 14, 2019
ryanrath
reviewed
Aug 14, 2019
ryanrath
reviewed
Aug 15, 2019
plessbd
reviewed
Aug 16, 2019
plessbd
reviewed
Aug 16, 2019
plessbd
reviewed
Aug 16, 2019
plessbd
approved these changes
Aug 16, 2019
plessbd
changed the title
Multi realm installs - Allow for modification of enabled realms with all tests passing
Multi realm installs - Allow for modification of enabled realms…
Aug 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integrate selection of desired realms to be enabled in XDMoD instance and allow all tests to pass based on which realms are enabled.
Description
Motivation and Context
It allows for the selection of realms to be enabled, where before there was no way to do so.
Tests performed
I ran all tests on every single combination (and order) of Jobs, Cloud, and Storage realms possible, using both the fresh_install and upgrade test modes, and all on fresh XDMoD instances.
I ran the same script commands that Shippable currently runs to do its tests of XDMoD. This included setting up a new XDMoD instance with the desired realms, and running regression, integration, component, UI, and all SSO tests on that instance.
Types of changes
Checklist: