Remove auto_login option. Always prompt for login if login required. #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The non-module-capable auto_login option is removed. The behaviour now is that a login box is created if you try to browse to a tab that is only available to logged in users.
plessbd
approved these changes
Apr 26, 2017
jtpalmer
approved these changes
Apr 26, 2017
tyearke
added
the
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The non-module-capable auto_login option is removed. The behaviour now
is that a login box is created if you try to browse to a tab that is
only available to logged in users.
Motivation and Context
Preliminary changes to support deep linking into the job viewer.
Tests performed
Yes