Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update DWI's isRealmEnabled to be config file based #1102

Merged
merged 3 commits into from
Oct 15, 2019
Merged

Update DWI's isRealmEnabled to be config file based #1102

merged 3 commits into from
Oct 15, 2019

Conversation

ryanrath
Copy link
Contributor

Description

  • Added a getEnabledRealms function that operates solely off of config files
    and not the db. This resolves some complexity / problems that arose with the
    ETL processes during install / upgrade.

Motivation and Context

Simplify the upgrade / install ETL by not requiring some DB tables to be present @ shred / ingest time.

Tests performed

  • Manual tests ( queries ) were performed to ensure that data was present where expected.
  • All automated tests were executed in both upgrade / install paths and passed.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project as found in the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@ryanrath
Update DWI's isRealmEnabled to be config file based
9e60917 
- Added a `getEnabledRealms` function that operates solely off of config files
  and not the db. This resolves some complexity / problems that arose with the
  ETL processes during install / upgrade.
@ryanrath ryanrath requested review from plessbd and jpwhite4 October 10, 2019 16:54
@ryanrath ryanrath requested a review from jpwhite4 October 10, 2019 19:13
@jpwhite4 jpwhite4 added this to the 8.5.0 milestone Oct 15, 2019
@ryanrath ryanrath merged commit 2198dec into ubccr:xdmod8.5 Oct 15, 2019
@plessbd plessbd added Category:Infrastructure Internal infrastructure updates/changes enhancement Enhancement of the functionality of an existing feature labels Oct 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpwhite4 jpwhite4 jpwhite4 approved these changes

@plessbd plessbd Awaiting requested review from plessbd

Assignees
No one assigned
Labels
Category:Infrastructure Internal infrastructure updates/changes enhancement Enhancement of the functionality of an existing feature
Projects
None yet
Milestone
8.5.0
Development

Successfully merging this pull request may close these issues.
3 participants
@ryanrath @jpwhite4 @plessbd