Remove redundant tokenize code

[jpwhite4]

Description

This change removes the unnecessary duplicate tokenize code. It also
replaces the function with a much simpler one that has full unit test
coverage.

Motivation and Context

General cleanup in preparation for deep linking support.

Tests performed

Ran the javascript unit_tests to confirm that the location hashes are parsed correctly. Ran code coverage
tools to confirm the new code has 100% test coverage (although the tools cannot check that all possible states have been hit in the regex state machine).

[plessbd]

did you do some basic before and after tests to show that the same input got the same output with old and new code?

[plessbd]

Will this new tokenize code break any existing code since this one always has the keys in the result?

xdmod/html/internal_dashboard/js/Dashboard/Viewport.js

Line 65 in feddfeb

var token = XDMoD.Dashboard.tokenize(document.location.hash);

xdmod/html/gui/js/modules/About.js

Line 130 in feddfeb

var item = decodeURIComponent(CCR.tokenize(Ext.History.getToken()).params);

xdmod/html/index.php

Line 506 in 4b606aa

var token = CCR.xdmod.ui.Viewer.viewerInstance.tokenize(hash);

etc

https://github.com/ubccr/xdmod/search?utf8=%E2%9C%93&q=tokenize&type=

[jpwhite4]

To answer your questions: 1) Yes I did test , 2) No it won't break anything.

I note that the XDMoD.Dashboard.tokenize function was not modified in any way so this code change does not impact any code that calls it.

[plessbd]

Screenshots or it didnt happen? :)

Looks Good To Me