Update cloud event schema and coerce data #1144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
During testing we found that the schema validation for cloud events was not actually validating anything due to a misconfiguration of the schema file. Instead of failing it just ignored everything. After updating the schema we also needed to ensure that type coercion was enabled as the data files encode `2` as `"2"`.
plessbd
approved these changes
Oct 31, 2019
jtpalmer
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
During testing we found that the schema validation for cloud events was not
actually validating anything due to a misconfiguration of the schema file.
Instead of failing it just ignored everything.
After updating the schema we also needed to ensure that type coercion was
enabled as the data files encode
2as"2".Motivation and Context
If we want to validate things then the validation should work.
Tests performed
all automated tests.
Types of changes
Checklist: