Improve search history panel UI. #1201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The search history in the job viewer always displayed all possible realms that could have search history regardless of whether there were any saved searches. This was reported as a bug by a user. The realm nodes in the tree would have a triangle mark indicating that the could be unfolded, but when the unfold was clicked then it would dissaper. This change makes it so that the search history only shows the realm folder nodes for realms that have search history. If there a no saved searches then an assist panel is shown.
|
Kudos, SonarCloud Quality Gate passed!
|
plessbd
approved these changes
Jan 15, 2020
jtpalmer
approved these changes
Jan 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The search history in the job viewer always displayed all possible
realms that could have search history regardless of whether there were
any saved searches. This was reported as a bug by a user. The realm
nodes in the tree would have a triangle mark indicating that the could
be unfolded, but when the unfold was clicked then it would dissaper.
old:
new:
This change makes it so that the search history only shows the realm
folder nodes for realms that have search history. If there a no saved
searches then an assist panel is shown.
There is a corresponding pull request in the supremm module that updates the UI tests to confirm the new code works.