Fix bugs in Configuration classes #1221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure function prototype is correct for cleanup() function. Ensure member variables are declared before they are used. These errors showed up when I was running the unit tests on my ubuntu box (php 7.2.24). It seems that earlier versions of php let you get away with it but not in later versions.
|
Kudos, SonarCloud Quality Gate passed!
|
jtpalmer
approved these changes
Jan 24, 2020
plessbd
approved these changes
Jan 24, 2020
jtpalmer
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure function prototype is correct for cleanup() function.
Ensure member variables are declared before they are used.
These errors showed up when I was running the unit tests on my ubuntu
box (php 7.2.24). It seems that earlier versions of php let you get away
with it but not in later versions.