Added regression tests for chart filters. #1250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These tests confirm that the chart filters filter the data correctly and have the correct chart subtitles. All filters available for each realm are tested with a single metric and group by none. This also includes the machinery to generate expected test results. The test for Cloud Filter by instance type is absent. This is because this filter does not work. Once the instance type filtering is fixed then a test should be added.
|
Note the sonar cloud analysis is a false positive. The crappy algorithm thinks that the code is duplicated because the file that changed has a symlink! |
plessbd
approved these changes
Mar 10, 2020
|
Why does the symlink need to exist? |
jtpalmer
added
Category:General
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These tests confirm that the chart filters filter the data correctly
and have the correct chart subtitles. All filters available for each
realm are tested with a single metric and group by none.
This also includes the machinery to generate expected test results.
The test for Cloud Filter by instance type is absent. This is because
this filter does not work. Once the instance type filtering is fixed
then a test should be added.