Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add referenced schema to foreign key constraints #1252

Merged
merged 1 commit into from
Mar 12, 2020

Conversation

jtpalmer
Copy link
Contributor

@jtpalmer jtpalmer commented Mar 11, 2020

Description

Add support for foreign key constraints that reference a schema that is different from the one that they belong to. Also refactor some tests.

Motivation and Context

It's possible for a foreign key constraint to reference a table in a different schema so the database model should support that.

See https://app.asana.com/0/15230011293693/1163079712082841

Tests performed

Added new tests.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project as found in the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@jtpalmer jtpalmer added Category:ETL Extract Transform Load new feature New functionality labels Mar 11, 2020
@jtpalmer jtpalmer added this to the 9.0.0 milestone Mar 11, 2020
@jtpalmer jtpalmer merged commit 35c22c2 into ubccr:xdmod9.0 Mar 12, 2020
@jtpalmer jtpalmer deleted the etl-fk-schema branch March 12, 2020 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category:ETL Extract Transform Load new feature New functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants