Improve robustness of integration and regression tests. #1256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The integration and regression tests should not get their test parameters from the system that they are testing. If the system to test is broken then the test may erroneously pass. In the case of the current fixes the old code was querying XDMoD to find out what realms existed and then only testing the realms that XDMoD reported as present. This is not the way it should be done. What should actually happen is that the developer sets up XDMoD with the desired set of realms and then the tests check that the desired set of realms are actually present.
plessbd
approved these changes
Mar 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The integration and regression tests should not get their
test parameters from the system that they are testing. If the
system to test is broken then the test may erroneously pass.
For this pull request: the old code was querying XDMoD
to find out what realms existed and then only testing the realms
that XDMoD reported as present. This is not the way it should be done.
What should actually happen is that the developer sets up XDMoD
with the desired set of realms and then the tests check that
the desired set of realms are actually present.