Remove unnecessary redirect in the job viewer rest stack. #1269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The job viewer rest api has an unusual code path to get the list of jobs for a given saved search. There is a 302 redirect when the interface gets the list of jobs. There is no 302 redirect for any of the other equivalent queries (such as list of information for a job). All of the required information to respond to the request is in the original request. This pull request removes the redirect. The path that wasa being redirected to still remains so as to not break compatibility with any external systems (they both call the same underlying function).
|
Note that this code path is tested in the UI tests. |
jtpalmer
approved these changes
Mar 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The job viewer rest api has an unusual code path to get the list of jobs
for a given saved search. There is a 302 redirect when the interface
gets the list of jobs. There is no 302 redirect for any of the other
equivalent queries (such as list of information for a job). All of the
required information to respond to the request is in the original request.
This pull request removes the redirect. The path that wasa being
redirected to still remains so as to not break compatibility with any
external systems (they both call the same underlying function).
This was observed while testing #1268