Add updating of version in module portal settings ini files on upgrade #1277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtpalmer
suggested changes
Mar 31, 2020
classes/OpenXdmod/Migration/Version851To900/ConfigFilesMigration.php
Outdated
Show resolved
Hide resolved
jtpalmer
approved these changes
Mar 31, 2020
jtpalmer
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added updating version variable in modules portal setting upon upgrade.
In appkernels version variable doesn't do much but it will be nice to have matching config version and software.
The big question is should it really be in core xdmod or in xdmod-appkernel. This would largely depends on how user is going to upgrade their system. In xdmod-upgrade, we did mentioned update supremm/appkernel tools first and then run xdmod-upgrade. Under this scenario it should work.
Since there are no other changes in appkernels.ini besides version and I don't anticipate any change in near future, just version update should be fine for a while.