Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update xdmod-check-config script #1327

Merged
merged 2 commits into from
Jun 4, 2020

Conversation

jtpalmer
Copy link
Contributor

@jtpalmer jtpalmer commented Jun 3, 2020

Description

Adds checks for PHP APCu and Multibyte String functions to make sure the corresponding extensions are installed and enabled.

Motivation and Context

When I was removing the mcrypt requirement I noticed that checks for these extensions were missing. These checks serve as a sanity check to assist in debugging.

Tests performed

Tested manually.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project as found in the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@jtpalmer jtpalmer added the Category:General General label Jun 3, 2020
@jtpalmer jtpalmer added this to the 9.0.0 milestone Jun 3, 2020
@jtpalmer
Copy link
Contributor Author

jtpalmer commented Jun 3, 2020

The test for mbstring isn't strictly necessary since we're including a polyfill (symfony/polyfill-mbstring is a dependency of a dependency of Silex). That brings up the question of why we include php-mbstring as a dependency of the RPM package if we're going to ship a polyfill.

@jtpalmer jtpalmer merged commit c686deb into ubccr:xdmod9.0 Jun 4, 2020
@jtpalmer jtpalmer deleted the update-check-script branch June 4, 2020 11:15
@jtpalmer jtpalmer added the enhancement Enhancement of the functionality of an existing feature label Aug 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category:General General enhancement Enhancement of the functionality of an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants