Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We have been running for some time without actually utilizing these tables and as such
it should be safe to remove them. These changes will make sure that the tables are not
created / referenced in ETL actions as well as making sure that they are removed in
existing installations when an upgrade is performed.
Motivation and Context
An error was encountered on Prod when a User that had existed when we were using the Roles / UserRoles tables and as such had records in the UserRoles table was deleted. Since UserRoles had a FK to
Users.id
the User removal failed and the Internal Dashboard / Existing Users Tab was put into an unusable state as the user in question still existed in the User table but did not have any ACL's associated with it, which broke the UI code, and thus the interface.Tests performed
All automated tests for upgrade / fresh install
Types of changes
Checklist: