Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update SQL delimiters #1384

Merged
merged 2 commits into from
Jul 20, 2020
Merged

Update SQL delimiters #1384

merged 2 commits into from
Jul 20, 2020

Conversation

jtpalmer
Copy link
Contributor

Description

Update SQL queries to use // or change configuration to specify ;. Also removes Roles table query.

Motivation and Context

The delimiter changes will fix any incorrect SQL statement counts and improve error reporting. The Roles tables isn't being used so that query should be removed.

Tests performed

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project as found in the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@jtpalmer
Update SQL delimiters
ae67b9f 
Also remove Roles table query.
@jtpalmer jtpalmer merged commit 6d32519 into ubccr:xdmod9.0 Jul 20, 2020
@jtpalmer jtpalmer deleted the etl-sql-delimiter branch July 20, 2020 13:52
@jtpalmer jtpalmer added bug Bugfixes Category:ETL Extract Transform Load labels Jul 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@plessbd plessbd plessbd approved these changes

Assignees
No one assigned
Labels
bug Bugfixes Category:ETL Extract Transform Load
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jtpalmer @plessbd