Fix bug where Usage Export dialog 'Show chart title' box had no effect #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plessbd
reviewed
May 9, 2017
| } | ||
|
|
||
| // Set the title style. | ||
| $meChart['title']['style'] = $usageTitleStyle; | ||
|
|
||
| // If the "Show Title" checkbox on the Export Dialog has no been ticked, |
There was a problem hiding this comment.
missing t, should be has not been ticked
There was a problem hiding this comment.
Presumably the comment was written in the south central sub-dialect of Central Scottish and is therefore correct.
tyearke
approved these changes
May 10, 2017
plessbd
approved these changes
May 10, 2017
chakrabortyr
pushed a commit
to chakrabortyr/xdmod
that referenced
this pull request
Oct 17, 2017
ubccr#139) * Fix bug where Usage Export dialog 'Show chart title' box had no effect
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix bug where Usage Export dialog 'Show chart title' box had no effect.
Description
Fix functionality of the "Show chart title" box on the Usage tab Export dialog. In the Metric Explorer, if the "Show chart title" box on the Export dialog is checked then the chart title is not shown. If there is a subtitle (added due to a filter, for example) then the subtitle is promoted to the title (explicitly set in
HighChart2::setChartTitleSubtitle()). The Usage tab now mimics this functionality.Motivation and Context
Bugfix.
Tests performed
Opened chart in metric explorer, added a filter, and verified that the "show chart title" checkbox properly removed the title and promoted the subtitle. Opened a chart in the Usage tab and verified that the "show chart title" checkbox properly removed the title and promoted the subtitle. Also clicked "open in Metric Explorer" gear and verified the expected behavior of the imported chart in the Metric Explorer.
Before bugfix plot includes title and subtitle, un-checked "Show chart title"
After bugfix plot includes title and subtitle, un-checked "Show chart title"
After bugfix plot includes title only, un-checked "Show chart title"
After bugfix plot includes title and subtitle, checked "Show chart title"
Types of changes
Checklist: