Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix chart last modified date (metric explorer) #140

Merged
merged 1 commit into from
May 10, 2017

Conversation

jsperhac
Copy link
Contributor

Description

  • Change to Metric Explorer javascript updates the timestamp on the current record of the queries store when a chart is saved.
  • Change to Metric Explorer controller parses the current timestamp from the request object and saves it, when saving the "query" associated with an existing chart. This step was previously missing.

Motivation and Context

Addresses xdmod6.6 bug: https://app.asana.com/0/14787510600562/335273737938313

Tests performed

Tests run by hand:

  • Alter existing ME charts, check displayed timestamp before and after saving and reloading.
  • Verify that no change is made to proper behavior: save existing chart under new name
  • Verify that no change is made to proper behavior: create new chart

Ran all unit and integration tests

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project as found in the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@smgallo
Copy link
Contributor

smgallo commented May 10, 2017

LGTM once the linter is fed and happy.

@jsperhac jsperhac merged commit 0c37718 into ubccr:xdmod6.6 May 10, 2017
@tyearke tyearke added this to the v6.6.0 milestone May 10, 2017
@tyearke tyearke added the bug Bugfixes label May 10, 2017
jsperhac added a commit that referenced this pull request May 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bugfixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants