Verifying User Query Count to address TrustedCI feedback #1430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change is to address https://app.asana.com/0/808093868887967/1188274656222915 . These problems were brought to our attention via our 2019 engagement with TrustedCI. Specifically, we now ensure that only a single user record is returned from these queries, anything else is considered an exception.
ryanrath
added
the
maintenance / code quality
plessbd
approved these changes
Aug 25, 2020
|
Just for future reference, every pull request that is intended to be included in the change log must have both a "Category" and non-"Category" label. Also, if you use the "maintenance / code quality" that indicates that it should NOT be included in the change log. Since you checked the "suitable for changelog" box I'm assuming that you do want this included. We may need to include all these instructions in the pull request template since it is not obvious. |
ryanrath
added
Category:General
|
Sounds good, I'll keep that in mind. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change is to address
https://app.asana.com/0/808093868887967/1188274656222915 . These problems were
brought to our attention via our 2019 engagement with TrustedCI. Specifically,
we now ensure that only a single user record is returned from these queries,
anything else is considered an exception.
Motivation and Context
Tests performed
automated tests were performed
Checklist: