Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change raw statistics variable substitution format #1448

Merged
merged 3 commits into from
Sep 17, 2020

Conversation

jtpalmer
Copy link
Contributor

@jtpalmer jtpalmer commented Sep 16, 2020

Description

Change the format used for variable substitution in rawstatistics.json configuration files.

This changes the syntax for variable substitution to match the format used by the ETL configuration files (as well as using the same PHP class). It also adds the other PHP constants that are not current used to the list of substitutions.

I'll update the upgrade documentation later since there will may be more changes made to the format of these files.

Motivation and Context

This is intended to make the substitutions more uniform with those used by the ETL and datawarehouse.json configuration file.

It is also a step working towards https://app.asana.com/0/342819846538629/1185671232325739/f

Tests performed

Tested manually in the job viewer.

Checklist:

  • The pull request description is suitable for a Changelog entry
  • The milestone is set correctly on the pull request
  • The appropriate labels have been added to the pull request

@jtpalmer jtpalmer added enhancement Enhancement of the functionality of an existing feature Category:General General labels Sep 16, 2020
@jtpalmer jtpalmer added this to the 9.5.0 milestone Sep 16, 2020
@jpwhite4
Copy link
Member

Will also need a corresponding change to the supremm stuff. Will be sufficient to switch out the:

fos_id: {
            name: "config://hierarchy.json:bottom_level_label",

in etl/js/config/supremm/etl.schema.js to:

fos_id: {
           name: "${HEIRARCHY...

or is it more complicated?

@jtpalmer
Copy link
Contributor Author

@jpwhite4 I'm hoping that's all that will need to change, but I haven't tested it yet.

@jtpalmer jtpalmer merged commit 70e2c67 into ubccr:xdmod9.5 Sep 17, 2020
@jtpalmer jtpalmer deleted the raw-stats-var-subs branch September 17, 2020 14:54
@jtpalmer jtpalmer modified the milestones: 9.5.0, 10.5.0 Feb 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category:General General enhancement Enhancement of the functionality of an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants