Move to using custom Ingestor for cloud resource specifications #1489
Conversation
| 'hostname' => $srcRecord['hostname'], | ||
| 'vcpus' => $srcRecord['vcpus'], | ||
| 'memory_mb' => $srcRecord['memory_mb'], | ||
| 'start_date_ts' => strtotime($srcRecord['start_date_ts'] . " 00:00:00"), |
There was a problem hiding this comment.
We conventionally use the _ts postfix to indicate that the data type is a posix timestamp. This looks like it is converting a datetime to a timestamp in place. Is this intended?
There was a problem hiding this comment.
@jpwhite4 Yeah, it is a datetime being converted to a timestamp. It's just wasn't named descriptively. I've changed the name to denote it is a date
|
This code does not generate correct SQL: #10 {main}","message":"xdmod.aggregate-cloud-resource-specs.CloudResourceSpecsAggregator (ETL\Aggregator\SimpleAggregator): Error processing aggregation period Exception: 'SQLSTATE[42000]: Syntax error or access violation: 1055 'modw_cloud.crs.vcpus' isn't in GROUP BY'"} In your tests I suggest merging #1469 so that the framework reports the errors. EDIT - I thought I was looking at your other pull request but had merged this one instead. However, this is a merge conflict with the other one. Which one do you want to merge first? |
| } | ||
|
|
||
| if ($this->_instance_state === null) { | ||
| if($srcRecord['vcpus'] == -1 && $srcRecord['memory_mb'] == -1) { |
There was a problem hiding this comment.
What scenario is handled here? When would you have the first record have vcpus and memory_mb as -1?
…m/eiffel777/xdmod into change-state-cloud-resource-specs
Move to using a custom Ingestor class for setting the start and end time for a host configuration in a cloud resource
Description
The custom Ingestor makes it easier to track when a host for a cloud resource changes the number of vcps or memory it contains and when a host may be taken out of a cloud resource.
Motivation and Context
This changes eliminates bugs in the previous implementation and makes it clearer to understand what is going on.
Tests performed
Tested in docker with fabricated test data and add new component tests
Checklist: