Enabled text selection / copying in Job Viewer Accounting Tab #1561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've made two changes to support text selection / copying in Job Viewer:
- Added a new css class that explicitly allows a user to select the text of
the element it is applied to.
- Updated the cell template used to render each cell of the `metrics` or
`keyvaluedata` tab types in the JobViewer. I specifically had to remove the
`x-unselectable` class and the `unselectable=on` element attribute. I also
added the new `selectable-text` css class so that it was clear that the
intent of the change was to make the text of these elements selectable.
ryanrath
added
enhancement
jtpalmer
approved these changes
Nov 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I've made two changes to support text selection / copying in Job Viewer:
the element it is applied to.
metricsorkeyvaluedatatab types in the JobViewer. I specifically had to remove thex-unselectableclass and theunselectable=onelement attribute. I alsoadded the new
selectable-textcss class so that it was clear that theintent of the change was to make the text of these elements selectable.
Motivation and Context
These changes were made to resolve: https://app.asana.com/0/search/1200856862261752/1200706315188842
Tests performed
All Automated tests.
Checklist: