Update Metric Explorer Controller to include ability to show all possible dimension values. #1578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
…rn all dimension values when allowed.
hltaylor26
force-pushed
the
ME_endpoint_show_all_dimensions
branch
from
22237d9
to
0e98b32
Compare
…oint. Previously it was not checking that user was authorized to view realm data, now access to realm data is still checked on when both flags are set to true for showAllDimensionValues.
jpwhite4
previously approved these changes
Dec 16, 2021
jpwhite4
approved these changes
Dec 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the Metric Explorer Controller so that all values for a specific dimension can be returned by getDimensionValues method despite a user's permissions. This allows histograms in the Efficiency Tab to display all dimension values as needed. The dimensions where this is allowed are stored in a configuration file by realm.
Corresponding changes need to be made to the etl_profile.js file to allow group_bys to have added show_all_dimension_vlaues flag. PR for this change is #1588.
Also, flag needs to be set to true in the SUPREMM module etl_schema.js file for each dimension allowed to show all values.
Motivation and Context
Allow Efficiency Tab to show all dimension values on drill down histogram.
Tests performed
Tested on metrics-dev and in docker.
Checklist: