Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance improvements to ETLv2 action that loads queues for jobs realm #1580

Merged

Conversation

eiffel777
Copy link
Contributor

The ETLv2 action for populating the modw.queue dimension table selects all the records in mod_hpcdb.hpcdb_jobs to get all queues that have been ingested. It seems unnecessary to try and re-ingest all the queues every time the ingestor runs. It also takes a long time, around 300 seconds. Instead, I think the action should get the queues from jobs listed in the mod_hpcdb.hpcdb_jobs_to_ingest table. This approach is much quicker, around 1 second or less.

Tests performed

Tested in docker and on metrics-staging

Checklist:

  • The pull request description is suitable for a Changelog entry
  • The milestone is set correctly on the pull request
  • The appropriate labels have been added to the pull request

@eiffel777 eiffel777 added enhancement Enhancement of the functionality of an existing feature Category:ETL Extract Transform Load labels Dec 10, 2021
@eiffel777 eiffel777 added this to the 10.0.0 milestone Dec 10, 2021
@eiffel777 eiffel777 self-assigned this Dec 10, 2021
@jpwhite4
Copy link
Member

Just want to confirm that the queue table is definitly not truncated by this action. I couldn't see where the 'truncate' flag was set.

@eiffel777
Copy link
Contributor Author

@jpwhite4 Yes, this action does not truncate the queue table. The default for truncate_destination is false as set in classes/ETL/aOptions.php and truncate_destination is not changed for this action or pipeline. Also, when running this action on metrics-staging I do not see the queue table being truncated.

@eiffel777 eiffel777 merged commit 0251f62 into ubccr:xdmod10.0 Dec 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category:ETL Extract Transform Load enhancement Enhancement of the functionality of an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants