-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix warnings seen when ingesting cloud or storage files #1592
Merged
eiffel777
merged 11 commits into
ubccr:xdmod10.0
from
eiffel777:fix-modw-cloud-shredder-warnings
Dec 22, 2021
Merged
Fix warnings seen when ingesting cloud or storage files #1592
eiffel777
merged 11 commits into
ubccr:xdmod10.0
from
eiffel777:fix-modw-cloud-shredder-warnings
Dec 22, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d-shredder-warnings
…d-shredder-warnings
…d-shredder-warnings
eiffel777
added
enhancement
Enhancement of the functionality of an existing feature
Category:ETL
Extract Transform Load
labels
Dec 16, 2021
jpwhite4
requested changes
Dec 17, 2021
…77/xdmod into fix-modw-cloud-shredder-warnings
jpwhite4
approved these changes
Dec 21, 2021
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Category:ETL
Extract Transform Load
enhancement
Enhancement of the functionality of an existing feature
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After merging PR #1586, MySQL warnings that were not displayed are now displayed. Those warnings come from the shredding of storage and cloud data.
For storage data, the
dt
column truncates the date string specified because it contains timezone information. Date time strings with timezones are not compatible withdatetime
columns. Changing this column to avarchar
and then usingSTR_TO_DATE
to get the correct date format fixes this warning. Since the timezone information does not appear to be used in the storage realm, this warning does not cause a bug.Example of storage data warning:
The date warning seen in the storage data exists for the cloud resource specifications as well. The warning is prevented by converting to a
varchar
column and usingSTR_TO_DATE
when loading the date into adatetime
column. The other warning is for thesize
column, defined asint(11)
. Thesize
field forimage.*
events are measured in bytes, and the Jetstream test data has images sizes that are too big for that column definition. The column can be changed to abigint
to fix this. Theimage.*
events are not used and discarded during ingestion, so this does not cause a bug or require a re-ingest of data.Example of warning for cloud resource specifications:
Example of warning for cloud events:
Tests performed
Tested in docker
Checklist: