Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor admin dashboard user listing query and add indexes to Users and SessionManager tables #1606

Merged
merged 2 commits into from
Feb 4, 2022

Conversation

jtpalmer
Copy link
Contributor

@jtpalmer jtpalmer commented Feb 4, 2022

Description

Refactor SQL and add indexes to moddb.Users and moddb.SessionManager tables.

Note that the SessionManager table is already included in the InnoDB migration so does not need to be included in the migration changes here.

Motivation and Context

User reported this query taking longer than a minute resulting in a time out in the admin dashboard.

https://app.asana.com/0/807770147051221/1201757805272796/f

https://ubccr.freshdesk.com/a/tickets/29169

Tests performed

Ran original query using development database and compared output with that from the new query.

Checklist:

  • The pull request description is suitable for a Changelog entry
  • The milestone is set correctly on the pull request
  • The appropriate labels have been added to the pull request

@jtpalmer jtpalmer added the enhancement Enhancement of the functionality of an existing feature label Feb 4, 2022
@jtpalmer jtpalmer marked this pull request as draft February 4, 2022 17:38
@jtpalmer jtpalmer added this to the 10.0.0 milestone Feb 4, 2022
@jtpalmer jtpalmer added the Category:Internal Dashboard Internal Dashboard label Feb 4, 2022
@jtpalmer jtpalmer marked this pull request as ready for review February 4, 2022 18:03
@ryanrath ryanrath self-requested a review February 4, 2022 19:12
@jtpalmer jtpalmer changed the title Refactor admin user listing query and add indexes Refactor admin dashboard user listing query and add indexes to Users and SessionManager tables Feb 4, 2022
@jtpalmer jtpalmer merged commit ea00715 into ubccr:xdmod10.0 Feb 4, 2022
@jtpalmer jtpalmer deleted the user-admin-query branch February 4, 2022 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category:Internal Dashboard Internal Dashboard enhancement Enhancement of the functionality of an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants