Add regression tests for usage explorer #165
Conversation
| $phpunit ${PHPUNITARGS} . | ||
| exit $? | ||
|
|
||
| #phpunit `dirname $0` |
There was a problem hiding this comment.
please remove the commented out code in this file.
| fi | ||
|
|
||
| $phpunit ${PHPUNITARGS} . | ||
| exit $? |
There was a problem hiding this comment.
Agreed, it will be removed
| fi | ||
|
|
||
| #PHPUNITARGS="" | ||
| PHPUNITARGS="--stop-on-error --stop-on-failure" |
There was a problem hiding this comment.
Why do you add these command line arguments that override the settings in the phpunit.xml.dist file? Why not set the phpunit.dist file with the settings that you want?
There was a problem hiding this comment.
For testing, this will be removed
| if(!empty($envUserrole)){ | ||
| self::$helper->authenticate($envUserrole); | ||
| } | ||
| $envBaseDir = getenv('REG_TEST_REGEX'); |
|
|
||
| Generating the expected results | ||
| ------------------------------- | ||
|
|
There was a problem hiding this comment.
since you have added a load of environment variables. please document them here.
|
Keep in mind this is a starting point and is specifically being used by me for federation based testing. I just wanted to get this out there as something that might be useful for others. @jpwhite4 and I have already had some discussions on how to make this more "generic" and useful for automated regression tests. However I dont have time to do all that work at the moment. |
Motivation and Context
Tests are good
Tests performed
These perform the tests
Types of changes