Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve handling of lock handling defaults #174

Merged
merged 1 commit into from
Jun 28, 2017

Conversation

smgallo
Copy link
Contributor

@smgallo smgallo commented Jun 27, 2017

Description

Improve handling of cases when no lock directory or lock file prefix are specified. Rather than using the current directory when a lock directory has not been provided, use the system temp directory. Default to a lock file prefix of "etlv2_" but allow specifying an empty string for no prefix. This eliminates the case where the code assumes that the current directory is the lock directory and "cleans" files that are not associated with a running process.

Motivation and Context

Tests performed

Yes

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project as found in the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@smgallo smgallo added enhancement Enhancement of the functionality of an existing feature Category:ETL Extract Transform Load labels Jun 27, 2017
@smgallo smgallo added this to the v7.0.0 milestone Jun 27, 2017
@smgallo smgallo requested a review from ryanrath June 27, 2017 20:41
@smgallo smgallo merged commit e145f77 into ubccr:xdmod7.0 Jun 28, 2017
@smgallo smgallo deleted the etl/lock-file branch June 28, 2017 13:59
ryanrath pushed a commit to ryanrath/xdmod that referenced this pull request Jul 24, 2017
chakrabortyr pushed a commit to chakrabortyr/xdmod that referenced this pull request Oct 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category:ETL Extract Transform Load enhancement Enhancement of the functionality of an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants