Updating Rest Logging to include the username #1809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanrath
added
data quality
eiffel777
previously approved these changes
Jan 11, 2024
eiffel777
reviewed
Feb 27, 2024
.circleci/config.yml
Outdated
| - save_cache: | ||
| key: v1-el8-dependencies-{{ checksum "composer.json" }} | ||
| paths: | ||
| - ./vendor |
There was a problem hiding this comment.
I think this same section is removed in #1810. Can this be moved into its own PR?
The `username` property was not being properly populated for rest request logging. This commit resolves that problem.
These changes make checking the contents of `log_table` much easier.
Just updating the username backfill SQL query to use the `JSON_EXTRACT` function as its more consistent than trying to use `INSTR/SUBSTR`.
ryanrath
force-pushed
the
fix-rest-logging
branch
from
35c27a2
to
716792a
Compare
eiffel777
approved these changes
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
usernameproperty was not being properly populated for rest request logging. This commit resolves that problem.I'll also be looking to resolve escaping in the log messages.
Motivation and Context
Tests performed
Checklist: