-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Highcharts conversion to Plotly JS #1822
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
aestoltm
added
Category:Metric Explorer
Metric Explorer / Usage
javascript
Pull requests that update Javascript code
php
Pull requests that update Php code
labels
Feb 14, 2024
aestoltm
requested review from
eiffel777,
jpwhite4,
nsimakov,
ryanrath,
aaronweeden and
connersaeli
February 20, 2024 16:23
…lues. 2) Putting arbitrary HTML tags in the title/axis titles/legend names. 3) Margin issues for titles with <br> tag.
…lots w/ trendline
aaronweeden
reviewed
May 6, 2024
aaronweeden
reviewed
May 6, 2024
aaronweeden
reviewed
May 6, 2024
aaronweeden
reviewed
May 6, 2024
aaronweeden
reviewed
May 6, 2024
aaronweeden
reviewed
May 6, 2024
aaronweeden
reviewed
May 6, 2024
aaronweeden
reviewed
May 6, 2024
ryanrath
reviewed
May 6, 2024
aaronweeden
reviewed
May 6, 2024
aaronweeden
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Category:Metric Explorer
Metric Explorer / Usage
javascript
Pull requests that update Javascript code
php
Pull requests that update Php code
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
These changes are for the Summary, Usage and Metric Explorer Tabs.
When finding a bug please compare with an instance running Highcharts so we know if this is an existing bug or not.
Features not in Plotly JS yet
Motivation and Context
Plotly JS has no license requirement which is desirable for Open XDMoD.
Tests performed
Tested on docker and dev-port. Will be converting the Playwright tests to work with Plotly JS.
Checklist: