Refactor REST warehouse raw data realm validation. #1895
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR refactors the validation of the
realm
parameter for REST requests to the warehouse raw data endpoint.Now, instead of responding with a message of
Invalid realm
, the message provides more information depending on the reason for the error:No realm exists with the requested name.
The requested realm is not configured to provide raw data.
Your user account does not have permission to get raw data from the requested realm.
In the last example above, it now responds with
403 Forbidden
instead of400 Bad Request
.Tests performed
In addition to updating the expected message in an integration test, I also updated my port on
xdmod-dev
and made sure the following tests passed with different roles and different realms, making the following request (replacing<token>
with the user's token and<realm>
with the realm):Checklist: