fix notices in xdsamlauth #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notices are thrown if the idp does not have the right indexes
jpwhite4
requested changes
Jan 10, 2017
| @@ -113,10 +113,10 @@ public function getLoginLink() | |||
| $orgDisplay = ""; | |||
| $icon = ""; | |||
| foreach ($idpAuth as $idp) { | |||
| if ($idp['OrganizationDisplayName']) { | |||
| if (array_key_exists('OrganizationDisplayName', $idp) && !empty($idp['OrganizationDisplayName'])) { | |||
There was a problem hiding this comment.
the array_key_exists is redundant as the empty() built-in does an isset() check and does not give a warning if the variable is not set. See e.g. http://php.net/manual/en/function.empty.php
changes per code review
jpwhite4
approved these changes
Jan 10, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
notices are thrown if the idp does not have the right indexes
Motivation and Context
Dont want to throw notices if they are not needed
Tests performed
Verified that the notices were no longer shown when display_errors = On in php.ini
Types of changes
Checklist: