-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding columns for resource, PI, and person organization ID for cloud realm #1936
Open
eiffel777
wants to merge
8
commits into
ubccr:main
Choose a base branch
from
eiffel777:add-resource-pi-organization-columns-cloud
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Adding columns for resource, PI, and person organization ID for cloud realm #1936
eiffel777
wants to merge
8
commits into
ubccr:main
from
eiffel777:add-resource-pi-organization-columns-cloud
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eiffel777
requested review from
jpwhite4,
ryanrath,
aaronweeden,
connersaeli and
aestoltm
October 28, 2024 15:47
jpwhite4
requested changes
Nov 22, 2024
@@ -24,7 +24,7 @@ public function execute() | |||
|
|||
if ($mysql_helper->tableExists('modw_cloud.event')) { | |||
Utilities::runEtlPipeline( | |||
['cloud-migration-10-5-0_11-0-0'], | |||
['cloud-migration-10-5-0_11-0-0','cloud-state-pipeline'], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be changed to an 11.0.0 -> 11.0.1 migration? We can't be modifying the 10.5 to 11.0 migration anymore since the 11.0.0 is released
…anization_id columns to cloudfact tables
…umns and remove resource_organization_id column from cloud realm
Co-authored-by: Aaron Weeden <31246768+aaronweeden@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the Resource, PI, and Person organization ID columns for the cloud realm. The
cloud-state-pipeline
etl pipeline has been added to the migration to re-aggregate the cloud realm so these columns are added and the columns are populated. These columns are used in the xsede module at this point in time.Tests performed
Tested in docker.
Checklist: