Enforce new code must have no errors or warns #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plessbd
changed the title
plessbd
approved these changes
Jan 14, 2017
Travis Ci will run the linter on any modifed js or php files. If there are errors or warnings, then lint will be run on the previous version of the file (if there was one). If new errors or warning have been introduced then the build is in error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Travis Ci will run the linter on any modifed js or php files. If
there are errors or warnings, then lint will be run on the previous
version of the file. If new errors or warning have been introduced then
the build is in error.
Motivation and Context
Improve the code quality for new code without putting an undue burden on developers to fix the existing code.
Tests performed
Tested using travis during development. Already running with this code on the xdmod-supremm module and tested by creating pull requests with different code changes.