Refactor Accounts Realm #50
Conversation
| ALTER TABLE `peopleonaccount` ADD KEY `aggregation_index` (`resource_id`,`account_id`,`person_id`,`start_time_ts`,`end_time_ts`,`allocationstate_id`); | ||
|
|
||
| ALTER TABLE `peopleonaccount` ENABLE KEYS; | ||
| UNLOCK TABLES; |
There was a problem hiding this comment.
Please add INSERT INTO schema_version_history VALUES ('modw', '6.6.0', NOW(), 'upgraded', 'N/A'); at the end of this file. Also, please update the schema version in db/data/modw.sql.
There was a problem hiding this comment.
Updated the schema version to 6.6.0 in db/data/modw.sql:
INSERT INTO schema_version_history VALUES ('modw', '6.6.0', NOW(), 'created', 'N/A');
| @@ -45,12 +39,10 @@ function __construct($dest_db, $src_db, $start_date = '1997-01-01', $end_date = | |||
| 'resource_id', | |||
| 'person_id', | |||
| 'allocationstate_id', | |||
| 'min_activity_time', | |||
| 'start_time', | |||
| 'end_time', | |||
| 'comments', | |||
| ) | |||
| ); | |||
| } | |||
| } | |||
There was a problem hiding this comment.
Is this file being used by ETLv2? It doesn't appear to be used anywhere in Open XDMoD. I tried adding it to the list of ingestors (in the old-style ETL), but get this error:
SQLSTATE[42S22]: Column not found: 1054 Unknown column 'poah.state_id' in 'field list'
... which isn't even related to your changes here. This looks like one of those classes that was copy/pasted from the TGcDB ingestors, but we aren't using it since we do not yet have the corresponding data in Open XDMoD.
There was a problem hiding this comment.
This isn't used in ETLv2 at all. If we're not using it in Open XDMoD then I'll remove it from the codebase and we can deal with it when we make modifications to support allocations/projects.
|
Addressed @jtpalmer comments |
tyearke
added
enhancement
* Minor improvements to ETLv2 logging * Remove unused min_activity_time column from peopleonaccount table * Add schema migration file * Updated schema versions and removed peopleonaccount ingestor
This is related to ubccr/xdmod-xsede#8 as well as https://tas-tools-int-01.ccr.xdmod.org/git/UBCCR/ccr-private-xdmod/pulls/6
Description
This PR includes minor debug improvements to display the DataEndpoint used in each query and removes the min_activity_time column from the peopleonaccount table since it is no longer used.
Motivation and Context
To provide the most accurate information possible.
Tests performed
See ubccr/xdmod-xsede#8
Types of changes
Checklist: