-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for cloud data to xdmod-shredder and xdmod-ingestor #739
Merged
eiffel777
merged 22 commits into
ubccr:xdmod8.1
from
eiffel777:add-cloud-ingestion-to-ingestor-script
Dec 20, 2018
Merged
Changes from 1 commit
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
ed0a524
Changes to xdmod-ingestor and xdmod-shredder to support cloud based e…
eiffel777 56ae3f9
adding checking for exception for when cloud table do not exist. adde…
eiffel777 c10909b
building filter list after running cloud aggregation in ingestor script
eiffel777 b55927a
add cloud shredder abstract class to reduce code duplication. renamed…
eiffel777 a1d9388
added new function to check if a realm is enabled before trying to in…
eiffel777 7074fc5
adding tests for new shredders
eiffel777 eef0291
adding phpdocs for realmEnabled function
eiffel777 901679b
documentation changes
eiffel777 b6d5609
style and test changes
eiffel777 ddf1eba
style changes
eiffel777 29c3801
adding newline that shouldn't have been deleted
eiffel777 e228e6d
use false instead of null to determine if realm should be aggregated
eiffel777 ebe18ad
change $realmToAggregate to default to false instead of null
eiffel777 64abdda
addressing nitpicks from @plessbd
eiffel777 37564c8
fixing merge conflict
eiffel777 30a5391
removing minmaxdate statement from bootstrap.sh
eiffel777 3ba69fc
Merge branch 'xdmod8.1' of https://github.com/ubccr/xdmod into add-cl…
eiffel777 c1af695
setting etl pipline to use for cloud shredders in constructor.
eiffel777 45db850
changes to get tests to pass
eiffel777 b60aa6b
update suggested by @plessbd
eiffel777 f3dc0ec
Merge branch 'xdmod8.1' into add-cloud-ingestion-to-ingestor-script
0eb33e0
Merge branch 'xdmod8.1' into add-cloud-ingestion-to-ingestor-script
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -7,14 +7,14 @@ | |
|
||
namespace OpenXdmod\Shredder; | ||
|
||
use CCR\DB\iDatabase; | ||
|
||
class OpenStack extends aCloud | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Should the filename match the class name There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Thanks for the catch. It's changed now. |
||
{ | ||
/** | ||
* @inheritdoc | ||
*/ | ||
public function shredDirectory($directory) | ||
{ | ||
$this->setEtlPipeline(['jobs-cloud-ingest-openstack']); | ||
return parent::shredDirectory($directory); | ||
public function __construct(iDatabase $db){ | ||
parent::__construct($db, ['jobs-cloud-ingest-openstack']); | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am so excited we are normalizing this data, before I was just fine.