Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed non-aggregate metrics being allowed in aggregate datasets #74

Merged
merged 2 commits into from
Mar 24, 2017

Conversation

tyearke
Copy link
Contributor

@tyearke tyearke commented Mar 24, 2017

Description

This pull request prevents metrics that cannot be accurately calculated from data that has been aggregated by fixed time periods from appearing in aggregate charts and datasets.

In the Metric Explorer, attempting to use one of these metrics on an aggregate chart will result in an error suggesting that the chart be switched to timeseries or that the metric in question be modified or deleted. In the Usage tab, since the only available option for any given chart is to switch to a timeseries chart, this is done automatically.

Motivation and Context

XDMoD should not be displaying data that isn't being calculated correctly. These metrics could be calculated correctly over arbitrary time periods if access to the raw data were readily available. However, getting access may require extensive rework, and this solves the issue in the short term.

Tests performed

I manually tested tabs with charts using Chrome to ensure modified metrics still worked and did not display in aggregate form. I also ran automated UI tests with Firefox and found no new regressions.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project as found in the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@tyearke tyearke added the bug Bugfixes label Mar 24, 2017
@tyearke tyearke added this to the v6.6.0 milestone Mar 24, 2017
@tyearke tyearke merged commit 4b9f162 into ubccr:xdmod6.6 Mar 24, 2017
@tyearke tyearke deleted the fixes/block-non-additive-aggregates branch April 4, 2017 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bugfixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants