Fixed non-aggregate metrics being allowed in aggregate datasets #74
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request prevents metrics that cannot be accurately calculated from data that has been aggregated by fixed time periods from appearing in aggregate charts and datasets.
In the Metric Explorer, attempting to use one of these metrics on an aggregate chart will result in an error suggesting that the chart be switched to timeseries or that the metric in question be modified or deleted. In the Usage tab, since the only available option for any given chart is to switch to a timeseries chart, this is done automatically.
Motivation and Context
XDMoD should not be displaying data that isn't being calculated correctly. These metrics could be calculated correctly over arbitrary time periods if access to the raw data were readily available. However, getting access may require extensive rework, and this solves the issue in the short term.
Tests performed
I manually tested tabs with charts using Chrome to ensure modified metrics still worked and did not display in aggregate form. I also ran automated UI tests with Firefox and found no new regressions.
Types of changes
Checklist: