Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enforce javascript unit tests #766

Merged
merged 1 commit into from
Jan 7, 2019
Merged

Enforce javascript unit tests #766

merged 1 commit into from
Jan 7, 2019

Conversation

jpwhite4
Copy link
Member

@jpwhite4 jpwhite4 commented Jan 3, 2019

The test harness was not correctly reporting when the javascript unit tests failed. This change
ensures that the test failures are properly reported to the CI infrastructure.

Also the tests were failing to run. This pull request includes the updates needed to get the tests running again:

  • polyfill for Array.prototype.includes() (which is missing from phantomjs but used in the code
  • script includes for the ExportPanel (needed by the job viewer)
  • populate the rawDataAllowedRealms variable.

@jpwhite4 jpwhite4 merged commit a363fad into ubccr:xdmod8.1 Jan 7, 2019
@jpwhite4 jpwhite4 deleted the js_units branch January 7, 2019 15:28
@jpwhite4 jpwhite4 added the qa / testing Updates/additions to tests label Mar 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@plessbd plessbd plessbd approved these changes

Assignees
No one assigned
Labels
qa / testing Updates/additions to tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jpwhite4 @plessbd