Fix test harness for javascript-based ETL code #781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plessbd
previously approved these changes
Jan 21, 2019
Also fix an error in the test harness that prevented the tests from running.
jpwhite4
force-pushed
the
fix_etltests
branch
from
43fa1ef to
2e9ff43
Compare
plessbd
approved these changes
Jan 21, 2019
jpwhite4
added a commit
to jpwhite4/xdmod-supremm
that referenced
this pull request
Jan 24, 2019
The changes in ubccr#107 required the expected test results to be updated. This was missed because the CI test resutls were not being checked. The CI tests were fixed in ubccr/xdmod#781
jpwhite4
added a commit
to ubccr/xdmod-supremm
that referenced
this pull request
Feb 8, 2019
Updates to CI tests needed by ubccr/xdmod#733 and ubccr/xdmod#781
smgallo
added
autodoc:ignore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The javascript-based ETL test harness was not setting the process exit code appropriately when the tests failed. In addition the tests were failing