-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ETLv2 Transform Step #80
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd-start-end-dates
…udes updated defaults for job records/tasks
…orm-step Conflicts: classes/ETL/Ingestor/pdoIngestor.php classes/ETL/Maintenance/VerifyDatabase.php
smgallo
added
enhancement
Enhancement of the functionality of an existing feature
Category:ETL
Extract Transform Load
labels
Mar 28, 2017
plessbd
approved these changes
Mar 28, 2017
ryanrath
pushed a commit
to ryanrath/xdmod
that referenced
this pull request
Apr 27, 2017
* Add transform() method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Category:ETL
Extract Transform Load
enhancement
Enhancement of the functionality of an existing feature
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a transform step to ETLv2 database ingestors.
Description
This PR adds the
pdoIngestor::transform()
method when operating in multi-database ingest mode. When iterating over the source data, each source record is passed to thetransform()
method, allowing transformation to be performed on the fields of each record. A child class can add additional transformations by overriding this method. Note that thepdoIngestor::transform()
method supports transforming a single source record into multiple destination records and therefore returns an array of records rather than a single record. If a child class overridespdoIngestor::transform()
, this is automatically detected via reflection inallowSingleDatabaseOptimization()
and the ingestor is put into multi-database mode.By default, the following transformation is applied.
parent::transform()
should be called prior to applying any local transforms.Also renamed "row" to "record" in the code and logs and updated the comments at the top of the file.
Note that only commit 6694905 is relevant, the rest got pulled in due to a merge and will be squashed.
Motivation and Context
@plessbd asked nicely.
Tests performed
Re-ran ingestion and re-checked job tables.
Types of changes
Checklist: