Relocate Tests #897

plessbd · 2019-04-19T14:06:22Z

The first commit is just a bunch of git mv folders.

git mv open_xdmod/modules/xdmod/regression_tests tests/regression
git mv open_xdmod/modules/xdmod/automated_tests/ tests/ui
git mv open_xdmod/modules/xdmod/component_tests/ tests/component
git mv open_xdmod/modules/xdmod/tests/ tests/unit
git mv open_xdmod/modules/xdmod/integration_tests/ tests/integration
git mv tests/xdmod-test-artifacts/xdmod tests/artifacts/xdmod
git mv tests/artifacts/xdmod/automated_tests tests/artifacts/xdmod/ui

The second is where the actual changing of files takes place.

The third commit is cleaning up the artifacts/xdmod/ json files

for file in `find . -type f -name '*.json'`; do echo $file && jq . -- "$file" >| /tmp/cleaned.json && \mv -f /tmp/cleaned.json "$file"; done

fourth commit fixes one last travis error.

tests is a wonderful directory for things such as regression, integration, ui, and unit tests to be located.

so I moved them there

automated_tests is a dumb name (thanks @plessbd) these have been renamed to ui
no need to have _tests in the folder names anymore since these are now properly located in a test directory

tests/ci

.secrets.json isnt a secret to anyone so created that under here so it doesnt ahve to be copied around
the scripts needed for ci are now here instead of under integration_tests/scripts

jpwhite4 · 2019-04-29T16:43:25Z

tests/component/lib/Utilities/LogAndThrowExceptionTest.php

@@ -45,7 +45,7 @@ public function testNoExceptionCode()
    public function testExceptionCode()
    {
        $msg = "Code = 10";
-        $excpectedMsg = (string) $this->loggable . " $msg";
+        $expectedMsg = (string) $this->loggable . " $msg";


How did this test pass before?

They were not running before, and currently are not running now. working with @ryanrath, @chakrabortyr, and @smgallo to get tests running and fix errors

jpwhite4 · 2019-04-29T16:43:52Z

tests/integration/lib/Controllers/BaseUserAdminTest.php

@@ -210,7 +210,7 @@ protected function createUser(array $options)
        $institution = isset($options['institution']) ? $options['institution'] : -1;
        $firstName = isset($options['first_name']) ? $options['first_name'] : 'Test';
        $lastName = isset($options['last_name']) ? $options['last_name'] : 'User';
-        $emailAddress = isset($option['email_address']) ? $options['email_address'] : $username . self::DEFAULT_EMAIL_ADDRESS_SUFFIX;
+        $emailAddress = isset($options['email_address']) ? $options['email_address'] : $username . self::DEFAULT_EMAIL_ADDRESS_SUFFIX;


How did this test pass before?

They were not running before, and currently are not running now. working with @ryanrath, @chakrabortyr, and @smgallo to get tests running and fix errors

jpwhite4 · 2019-04-29T16:45:15Z

tests/ui/wdio.conf.js

@@ -218,7 +218,7 @@ exports.config = {
            if (webdriverHelpers.hasOwnProperty(extension) && typeof webdriverHelpers[extension] === 'function') {
                browser.addCommand(extension, webdriverHelpers[extension].bind(browser));
            } else {
-                console.warning('Not Adding: ', extension, typeof webdriverHelpers[extension]);
+                process.stderr.write('Not Adding: ' + extension + typeof webdriverHelpers[extension]);


Note that this code will produce different output to the previous code.

yes, however, this is for the most part only for "developers" when running this and should rearely if ever be hit.

jpwhite4 · 2019-04-29T16:47:06Z

tests/ci/README.md

+If you look in `assets/copy-caches.sh` you will see all of the files that will be put into place.
+
+### vimrc
+This is just some defaults for VIM when useing the docker for development


s/useing/using/

Fixing issues introduced by ubccr#897. Mostly it was just updating hard coded paths, but there are a few places where the format of the expected data json files are important ( ETLv2 Directory Scanner Tests ). This required re-formatting of the affected files per their use case. The

* Updated to allow query descriptors to control visibility ** acl-config ** Previously we only allowed statistics to determine if an `acl_group_by` record was visible or not. But our config files seem to indicate that certain query descriptors should be able to control their ability to be shown as well. To support both of these use cases the `processQueryDescriptors` function in `acl-config` has been updated to take into account the `hide` property defined at the query descriptor level and the `visible` property defined at the statistic level. The logic used to determine the final visibility of an `acl_group_by` record is as follows. - By default all entries are shown - If `visible` is defined then we use it's value. - Else, if `hide` is defined then we use it's value. Also, there was a minor refactor with the removal of the `$enabled` variable. The `$disable` variable that it was based on was never going to be null, so it's use could be replaced w/ just `!$disable`. ** Acls ** There was some minor cleanup done because it was determined that we always want to have the `visible` column included, not just when a `$statisticName` is provided. This allowed us to move the `$descripter->setShowMenu(...)` from out of the `if(isset($statisticName)) { ... }` guard so that all query descriptors generated by this function will have their `showMenu` property populated. These two sets of changes work together to allow us to control our UI state as we expect to. * Fixing Tests Fixing issues introduced by #897. Mostly it was just updating hard coded paths, but there are a few places where the format of the expected data json files are important ( ETLv2 Directory Scanner Tests ). This required re-formatting of the affected files per their use case. The * Adding a step to account for the User Profile Prompting The User Profile pops up to prompt the user to double check their email address. This means that the ext-mask-msg will be present until the user clicks close, thus causing a problem for the `Logout` step. * Style Fixes * Adding tests for `get_menus` endpoint This is just the initial bootstrap commit for the new `get_menus` endpoint integration tests. * Adding additional Tests Added tests for `controllers/user_interface.php/operation=get_menus` and for `Acls::getDisabledMenus`. `get_menus` is the endpoint that provides the list of of query descriptors visible to the user. While `getDisabledMenus` provides the list of query descriptors that are disabled. This should provide us a with a set of happy path tests for these two sets of functionality that can later be expanded upon as needed. * Updated artifacts to be posix compliant aka. added newlines

plessbd mentioned this pull request Apr 19, 2019

moving tests #896

Closed

plessbd changed the title ~~Reloc tests take 3~~ Relocate Tests Apr 19, 2019

plessbd requested review from jtpalmer, ryanrath and smgallo April 19, 2019 14:41

plessbd force-pushed the reloc-tests-take-3 branch from 0651f20 to b9bfcd6 Compare April 19, 2019 15:44

plessbd added this to the 8.5.0 milestone Apr 19, 2019

plessbd added autodoc:ignore Auto documentation ignore this PR data quality Data quality issues such as improvements to sql queries to improve precision or consistency qa / testing Updates/additions to tests labels Apr 19, 2019

plessbd force-pushed the reloc-tests-take-3 branch 6 times, most recently from d4cfe6b to 154f5e3 Compare April 23, 2019 17:27

plessbd changed the base branch from xdmod8.1 to xdmod8.5 April 23, 2019 19:05

plessbd force-pushed the reloc-tests-take-3 branch from 154f5e3 to db4c67f Compare April 27, 2019 03:03

plessbd requested a review from eiffel777 April 29, 2019 12:32

plessbd and others added 6 commits April 29, 2019 10:43

All the git mv's

70684c2

Actual modification

62624bb

Test Artifacts POSIX EOL jq Pretty

b321eed

Travis shall be happy!

20eae42

Cleanup Warnings

1136cd5

move new test added in upstream

5479a0a

plessbd force-pushed the reloc-tests-take-3 branch 2 times, most recently from e9766d7 to 5479a0a Compare April 29, 2019 15:55

jpwhite4 reviewed Apr 29, 2019

View reviewed changes

jpwhite4 approved these changes Apr 29, 2019

View reviewed changes

plessbd merged commit 8e9ea0e into ubccr:xdmod8.5 Apr 29, 2019

plessbd deleted the reloc-tests-take-3 branch April 29, 2019 19:08

jpwhite4 added a commit to jpwhite4/xdmod that referenced this pull request Apr 30, 2019

Move test file to new location (required by ubccr#897)

caae92e

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Relocate Tests #897

Relocate Tests #897

plessbd commented Apr 19, 2019 •

edited

Loading

jpwhite4 Apr 29, 2019

plessbd Apr 29, 2019 •

edited

Loading

jpwhite4 Apr 29, 2019

plessbd Apr 29, 2019 •

edited

Loading

jpwhite4 Apr 29, 2019

plessbd Apr 29, 2019

jpwhite4 Apr 29, 2019

Relocate Tests #897

Relocate Tests #897

Conversation

plessbd commented Apr 19, 2019 • edited Loading

jpwhite4 Apr 29, 2019

Choose a reason for hiding this comment

plessbd Apr 29, 2019 • edited Loading

Choose a reason for hiding this comment

jpwhite4 Apr 29, 2019

Choose a reason for hiding this comment

plessbd Apr 29, 2019 • edited Loading

Choose a reason for hiding this comment

jpwhite4 Apr 29, 2019

Choose a reason for hiding this comment

plessbd Apr 29, 2019

Choose a reason for hiding this comment

jpwhite4 Apr 29, 2019

Choose a reason for hiding this comment

plessbd commented Apr 19, 2019 •

edited

Loading

plessbd Apr 29, 2019 •

edited

Loading

plessbd Apr 29, 2019 •

edited

Loading