Fix backup table detection bug in acl-config.
#920
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So it turns out that PHP prepared statement variable binding doesn't play well with SQL `IN` statements. Just moving things around a bit so that instead of supplying the `IN` clause w/ a bind parameter we instead just populate it in the base query string.
jtpalmer
approved these changes
May 7, 2019
chakrabortyr
reviewed
May 7, 2019
jpwhite4
changed the title
tablesExistacl-config.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
So it turns out that PHP prepared statement variable binding doesn't play well
with SQL
INstatements. Just moving things around a bit so that instead ofsupplying the
INclause w/ a bind parameter we instead just populate it in thebase query string.
This PR is related to: https://ubccr.freshdesk.com/a/tickets/12470
Motivation and Context
It's nice to have a
recovermode that actually functionsTests performed
Manual Tests performed on a local docker instance.
Types of changes
Checklist: