Less stringent DataWarehouse Descripter tests #926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plessbd
force-pushed
the
update-get-dw-tests
branch
from
1401732 to
38f39dc
Compare
chakrabortyr
previously approved these changes
May 13, 2019
plessbd
force-pushed
the
update-get-dw-tests
branch
2 times, most recently
from
5ebef00 to
e5445d4
Compare
ryanrath
previously approved these changes
May 13, 2019
plessbd
force-pushed
the
update-get-dw-tests
branch
from
64c59c9 to
faed835
Compare
plessbd
force-pushed
the
update-get-dw-tests
branch
from
faed835 to
5cf10c9
Compare
ryanrath
requested changes
May 14, 2019
plessbd
force-pushed
the
update-get-dw-tests
branch
from
5cf10c9 to
cfc3b71
Compare
ryanrath
approved these changes
May 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't really care "what" comes back.
As we shouldnt have to change the tests for verbiage updates, a PR updating those will contain the discussions on how it should say, the tests just verify that something comes back.
We care that a list of realms with dimensions and metrics comes back and that each dimension and metric has the expected information.