Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Fixes and Changes #979

Merged
merged 3 commits into from
Jul 23, 2019
Merged

Bug Fixes and Changes #979

merged 3 commits into from
Jul 23, 2019

Conversation

mkzia
Copy link
Contributor

@mkzia mkzia commented Jul 16, 2019

Description

This PR fixes/changes the following things:

​​1. Duration selected for report charts is now indicated using a bold period
2. Config file how uses 'timeframe' instead of 'role' to specify the timeframe
3. Change template name to 'Summary Page Report' which is more descriptive
4. Set report schedule to once
5. Change 'recent' to 'saved'
6. Show unknown data in saved charts and reports portlet
7. Show current time range selection
8. Add icon class to time range selection
9. Adjust spacing summary report portlet
10. Inherit charts and report portlet form Greg's portlet

Motivation and Context

Bug fixes reported by Joe and modifications discussed in the meeting.

Tests performed

Manual tests

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project as found in the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@mkzia mkzia changed the title Fix bugs Bug Fixes Jul 16, 2019
@mkzia mkzia force-pushed the bug_fixes branch 2 times, most recently from 8c28fd6 to e66dfc4 Compare July 16, 2019 18:37
@mkzia mkzia requested a review from jpwhite4 July 16, 2019 19:11
@mkzia mkzia changed the title Bug Fixes Bug Fixes and Changes Jul 17, 2019
@jpwhite4 jpwhite4 added this to the 8.5.0 milestone Jul 22, 2019
@jpwhite4 jpwhite4 merged commit 2fd23bd into ubccr:xdmod8.5 Jul 23, 2019
@plessbd plessbd added the Category:User Dashboard Screen shown after user login label Aug 8, 2019
@plessbd plessbd added the bug Bugfixes label Oct 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bugfixes Category:User Dashboard Screen shown after user login
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants