This repository has been archived by the owner on Feb 18, 2021. It is now read-only.
Speed up test by reordering integration test first, then unit test #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thuningxu
force-pushed
the
testbuild
branch
3 times, most recently
from
96328a6 to
bdeaf69
Compare
thuningxu
force-pushed
the
testbuild
branch
2 times, most recently
from
a39b0f3 to
64e2660
Compare
venkat1109
approved these changes
Apr 20, 2017
Makefile
Outdated
| cat $(BUILD)/"$$dir"/coverage.out | grep -v "mode: atomic" >> $(BUILD)/cover.out; \ | ||
| done | ||
|
|
||
| cover_profile: lint cover_prepare cover_integration cover_unit |
There was a problem hiding this comment.
can you move the cover_prepare as a dep for targets cover_unit and cover_integration instead of adding that as a dep here ?
just want to make sure running make cover_unit also works
Makefile
Outdated
| @@ -100,20 +100,21 @@ cherami-store-tool: $(DEPS) | |||
|
|
|||
| bins: cherami-server cherami-replicator-server cherami-cli cherami-admin cherami-replicator-tool cherami-cassandra-tool cherami-store-tool | |||
|
|
|||
| cover_profile: lint bins | |||
| @echo Running tests: | |||
| cover_profile: lint $(DEPS) | |||
There was a problem hiding this comment.
I think you still want the bins as a dep instead of DEPS
.travis.yml
Outdated
| @@ -71,6 +71,7 @@ install: | |||
|
|
|||
| script: | |||
| - EMBEDROCKSDB=0 make cover_ci | |||
There was a problem hiding this comment.
you can just add j2 here and remove the next line (see comment below)
|
Changes Unknown when pulling 5b8c306 on testbuild into ** on master**. |
thuningxu
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the title.