This repository has been archived by the owner on Feb 18, 2021. It is now read-only.
Add auth resource to CreateConsumerGroup and refactor code a little bit #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Changes Unknown when pulling 4f48ff9 on security8 into ** on master**. |
datoug
reviewed
May 25, 2017
| authResource := common.GetResourceURNCreateConsumerGroup(h.SCommon, createRequest.DestinationPath) | ||
| err = h.GetAuthManager().Authorize(authSubject, common.OperationRead, common.Resource(authResource)) | ||
|
|
||
| err = h.checkAuth(ctx, authResource, common.OperationRead, lclLg) |
There was a problem hiding this comment.
should OperationRead actually be OperationCreate?
There was a problem hiding this comment.
Here we use "Read Destination" as the permission to create consumer group. Try to model the CRUD permission on destination.
datoug
approved these changes
May 25, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.